Skip to content

Rename $finishHandler to $finalHandler for consistency - #333

Merged
vjik merged 2 commits into
masterfrom
rename-finish
Sep 10, 2026
Merged

Rename $finishHandler to $finalHandler for consistency#333
vjik merged 2 commits into
masterfrom
rename-finish

Conversation

@vjik

@vjik vjik commented Sep 9, 2026

Copy link
Copy Markdown
Member
Q A
Is bugfix?
New feature?
Breaks BC? ✔️
Tests pass? ✔️

@vjik
vjik requested a review from a team September 9, 2026 08:09
@codecov

codecov Bot commented Sep 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.50%. Comparing base (8937f11) to head (1619962).

Files with missing lines Patch % Lines
src/Middleware/Push/PushMiddlewareDispatcher.php 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master     #333   +/-   ##
=========================================
  Coverage     92.50%   92.50%           
  Complexity      383      383           
=========================================
  Files            59       59           
  Lines          1014     1014           
=========================================
  Hits            938      938           
  Misses           76       76           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vjik vjik added the status:code review The pull request needs review. label Sep 9, 2026
@vjik
vjik merged commit ae44e2b into master Sep 10, 2026
28 of 29 checks passed
@vjik
vjik deleted the rename-finish branch September 10, 2026 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:code review The pull request needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants