Repository navigation
Conversation
The header reader ends a line at a NUL, so "Content-Length: 16\0, 8" hid the ", 8", and a NUL before the line end could end the header block early. RFC 9110 section 5.5 lets a recipient reject such a field or replace the NUL with a space. Rejecting is the safer choice: a space would let the hidden value through, and #2237 already drops a response whose framing headers cannot be trusted. Closes #2238 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
Add fixtures for a Set-Cookie before the NUL line, a NUL in the status line, a NUL-filled body and a headerless reply holding a NUL, and run the error count last so each mutant fails on its own assertion. Make the htsback.c comments accurate and translate the French ones touched. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
xroche
enabled auto-merge (squash)
November 14, 2026 17:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
httrack now drops a response whose header holds a NUL byte, because its line reader stops at the NUL and hides the fields after it. RFC 9110 section 5.5 also allows a space in place of the NUL, but rejecting is safer and matches how #2237 drops untrusted framing.
Closes #2238