Repository navigation
Stop the -%N0 type probe at once on an abort lock - #2235
Merged
Merged
Conversation
The engine read hts-abort.lock only in its main loop. The -%N0 type probe waits on each link's reply in its own loop. So a lock written there took effect only after every remaining link was probed, which took 14s on test 436's slow server. #2234 fixed the same wait for SIGTERM. hts_poll_abort_request() now does the read, log and exit_xh store that both main-loop sites repeated, and the probe loop calls it too. Test 436 probes /slowhead/ and fails without the new call. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
…n p0 write_lock_request can retry for about 3s on drvfs, which the 4s bound must not count. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An abort lock written during the
-%N0link-type probe now stops the crawl at once. Before, the crawl first probed every remaining link, which took 14s in test 436. This is the lock-file half of #2234, which fixed the same wait for SIGTERM. I also tried a poll in the slot wait (hts_wait_available_socket) and dropped it, because no crawl I could build needed it.