Repository navigation
Read the cookie bounds from cookie_set_impl() - #282
Merged
Merged
Conversation
Engine master moved the body of cookie_set() into a static cookie_set_impl(), so the encoding job could no longer find the COOKIE_MAX_PAIR checks and failed. The engine still applies them. Read cookie_set_impl() when it exists and cookie_set() otherwise. The test passes against engine 7a923f40 and 3.51.0 (b0972289). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Engine master moved the body of
cookie_set()into a new staticcookie_set_impl(), andtools/test-cookie-file.pyread only thecookie_set()region. So theencodingjob failed with "cookie_set() no longer holds the name to COOKIE_MAX_PAIR", although the engine still applies that bound. The test now readscookie_set_impl()when it exists andcookie_set()otherwise. It passes against engine 7a923f40 and 3.51.0.