Repository navigation
Bump the vendored engine to 7a923f40, engine master - #273
Merged
Merged
Conversation
The engine factored library code out of its existing files, which adds two things the Android build needs. src/htsbase.c joins the explicit source list, and -DHTS_INTERNAL_BYTECODE shows libhttrack the engine-only half of the headers. Without the macro every engine file fails to compile, because the internal prototypes are now hidden behind it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
The engine now refuses a -%c rate between zero and 0.000001, and one above a float, where it used to cast whatever it read (engine #2081). The rate field takes any decimal and no layout bounds it, so a user-typed 0.0000001 would abort the crawl before it starts. A magnitude clamps to the bound it passed, per the rule a profile value follows everywhere else here. The added test reads both bounds back out of the engine source, so a moved floor fails here instead of shipping a rate the engine panics on. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The engine moved 102 commits, mostly a factorization meant to keep behavior the same. Two of its changes reach this build, so Android.mk gains both: the new library source
src/htsbase.c, and-DHTS_INTERNAL_BYTECODE. Without the macro the internal prototypes stay hidden and every engine file fails to compile.The bump also turns one front-end value fatal. The engine now refuses a
-%crate between zero and 0.000001. The rate field takes any decimal, so a user-typed 0.0000001 would abort the crawl before it starts. The mapper clamps such a rate to the bound it passed.Both ABIs build and 678 unit tests pass.