Repository navigation
Keep decimal precision when reading through the schema - #182
Open
vtxe02023274 wants to merge 1 commit into
Open
vtxe02023274 wants to merge 1 commit into
vtxe02023274 wants to merge 1 commit into
Conversation
With UseSchema, a float scalar resolved to a double before it was converted to decimal, so 1234567890.123456789 read as 1234567890.12346. Read the decimal from the scalar text, as the default path does, and keep the double conversion as a fallback.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
UseSchema = true,YamlScalar.TryParseDecimal(YamlReader, ...)takes the value the schema resolved. For a float that value is adouble, so adecimalmember only keeps about 15 significant digits:When the schema resolves a float, the decimal is now read from the scalar text, same as the default path. The schema still decides whether the scalar is a number, and the old double conversion stays as the fallback, so
!!float 0x10still reads as 16 and.infstill fails.Added
DecimalKeepsItsPrecisionInBothPathstoYaml122SchemaTests; it fails before the change.dotnet test -c Release: 2517 passed.