Repository navigation
Conversation
- Lay the two options side by side only from lg, so the expiration inputs get the full card width on medium screens - Group the options in a fieldset with a legend, and name each radio by its title with its description linked separately - Build the setting card from CardHeader, CardTitle and CardDescription - Add tests for the choice control and for how the settings reach the offer dialogs
Rigidity
force-pushed
the
rigidity/redesign-create-offer-cards
branch
from
November 15, 2026 04:29
58a0e17 to
0ab0b34
Compare
- Drop OfferChoice's per-option details and disabled state, which nothing uses since expiration and coin splitting became switches - Test that each typed fee reaches the dialog, and that an NFT row that hasn't been filled in doesn't count as an offered NFT
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The create offer page had become cluttered. This redesign takes its layout from ent-wallet's create offer screen:
The setting card (
OfferSettingCardinsrc/components/OfferSettings.tsx) takes an optional switch for its header. The NFT Offers choice (OfferChoice) uses native radio inputs in a fieldset, so it doesn't add a dependency. What the page passes to offer creation is unchanged, andsrc/pages/MakeOffer.test.tsxchecks the settings that reach the confirmation dialog.Review
Two review loops, each run with separate correctness, tests and simplification reviewers. The second loop ran after the switch change and the rebase onto main. Neither found anything at major or above. Fixes from the second loop:
OfferChoiceno longer has per-option details or a disabled state, which nothing has used since expiration and coin splitting became switches.Decisions to confirm
MakeOffer.tsx.New strings are wrapped with Lingui; the next release needs
pnpm extract.