Repository navigation
Conversation
added 2 commits
October 29, 2026 09:16
Stdlib.exit calls flush_all which does a blocking write() on every unflushed out_channel. One stale channel whose fd was reused by an unread socket blocks it forever. Use Unix._exit instead which doesn't call flush_all. Signed-off-by: Bengang Yuan <bengang.yuan@citrix.com>
Start a timer in the fuse process to force exiting the process if it is still running fuse_exit_grace seconds (default 60) after the fuse delay. Signed-off-by: Bengang Yuan <bengang.yuan@citrix.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the fuse exits xapi,
Stdlib.exitrunsflush_all, which can block forever writing a stale channel whose fd has been reused by an unread socket. The process then never exits.Unix._exitinstead ofStdlib.exit, which skipsflush_all.fuse_exit_graceseconds (default 60) after the fuse delay.