Repository navigation
Two witness opening - #508
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
CSP benchmarks
Prover time, peak RSS, peak heap, and verifier time are arithmetic means across the iterations. Peak heap comes from the largest Each metric cell shows the current value followed by the percentage delta against the latest successful Results
|
zkfriendly
marked this pull request as ready for review
October 14, 2026 10:03
zkfriendly
force-pushed
the
zkfr/two-witness-opening
branch
from
October 19, 2026 07:45
77a39b4 to
512f552
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #493
Add joint WHIR opening for ProveKit’s two-stage witnesses.
The prover and verifier call WHIR’s
prove_pairandverify_pairdirectly.How it works
After the Spartan sumcheck, each matrix claim has contributions from both witness stages.
For witnesses$w_1,w_2$ and coefficient vectors $L_1,L_2$ , combine those contributions:
Split matrix columns at the original witness boundary, then pad each block to the same size.
Represent the combined form with a selector coordinate:
The selector chooses the first block at$s=0$ and the second block at $s=1$ .
Apply this construction to A, B, and C. WHIR opens the combined claims against the two existing commitments and returns one shared evaluation point.
Implementation
FinalClaim::verify.The Spartan blinding commitment retains its separate opening.
Tests
Tests cover:
Arkworks compatibility
Both joint-opening branches now use Arkworks 0.6 and the matching published Spongefish dependencies.
The temporary Arkworks 0.5 configuration is removed.