Repository navigation
feat: add deep face failure reason enum - #364
Closed
danielle-tfh wants to merge 1 commit into
Closed
danielle-tfh wants to merge 1 commit into
danielle-tfh wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
danielle-tfh
marked this pull request as ready for review
October 28, 2026 14:19
danielle-tfh
requested review from
Guardiola31337,
Takaros999,
chipp,
kchaw2005,
murph and
paolodamico
as code owners
October 28, 2026 14:20
Contributor
|
this doesn't achieve what we want, let me make a PR for it |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
defines the deep face failure
reasonvocabulary once so world app and relying parties share it.Notes
DeepFaceFailureReasonnext toAppErrorinrust/core/src/error.rs- same derives (serde snake_case, uniffi enum underffi,EnumIterunderconformance), plusfrom_codereasonstays optional and is not wired intoStatusyet. unknown strings parse asunknown, so this is additiveDEEP_FACE_FAILURE_REASONS, theDeepFaceFailureReasontype and adeepFaceFailureReason()parser from@worldcoin/idkit-core- same shape asAPP_ERROR_CODES/IDKitErrorCodecargo fmt,cargo clippy --all-targets --all-features -D warnings,cargo test -p idkit-core(with and withoutconformance),pnpm lint:js,pnpm build,pnpm type-check,pnpm test,pnpm test:conformance(all green; the fast-check case needed--testTimeout=120000locally, it times out at 5s on the debug binary)Note
Low Risk
Additive enum and exports with unknown-string fallback; no changes to verification flow, auth, or result shaping.
Overview
Introduces a shared vocabulary for World App’s optional Deep Face bridge
reason(alongsideerror_code), aligned with iOS/Android so RPs and apps parse the same snake_case strings.Rust adds
DeepFaceFailureReasonnext toAppError(serde, UniFFI,from_code,#[serde(other)]→unknown). JS exportsDEEP_FACE_FAILURE_REASONS, theDeepFaceFailureReasontype, anddeepFaceFailureReason()for unrecognized values.The conformance manifest now includes
deep_face_failure_reasons, with runtime and compile-time checks so Rust and@worldcoin/idkit-corecannot drift.reasonis not wired intoStatusyet—this is additive parsing/types only.Reviewed by Cursor Bugbot for commit 0654b35. Bugbot is set up for automated code reviews on this repo. Configure here.