Repository navigation
fix(events): Remove the unsupported order option from listEvents - #1747
Merged
Merged
Conversation
GET /events has never honored `order`; it returns events oldest first and pages with `after` only. The API reference stops documenting it in workos/workos#78349, so the SDK stops offering it too. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
[Low impact] The PR appears safe to merge. SummaryRemoves the unsupported
Reviews (1) · Last reviewed commit: "fix(events): Remove the unsupported orde..." · Reviewed by Greptile |
gjtorikian
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
GET /eventshas never honoredorder: it returns events oldest first and pages withafteronly. workos/workos#78349 removes the parameter from the API reference and OpenAPI spec, and the SDK should stop offering it too.This drops
orderfromListEventOptionsand from the query the SDK sends. Nothing changes on the wire for callers who never set it, which the SDK never did by default. A caller who did setordergets a type error on upgrade; the value was ignored by the API, so removing it from the call is the whole fix.Release note: I titled this
fix(events)without!, treating it as a bugfix per the discussion. If you would rather cut it as a breaking change for the type removal, retitle with!before merging.Verified locally:
typecheck,eslint src/events,prettier --checkon the changed files, andjest src/events/events.spec.ts(36 passing after removing the test that assertedorderwas sent).Documentation
Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.
The reference change ships in workos/workos#78349; nothing further is needed for this PR.
🤖 Generated with Claude Code