Repository navigation
Conversation
Contributor
[Low impact] The PR appears safe to merge after its prerequisite, PR #131. SummaryAdds support for
Reviews (1) · Last reviewed commit: "fix(deps): support @workos-inc/node 12" · Reviewed by Greptile |
Base automatically changed from
devin/1793906475-bump-authkit-session
to
main
November 6, 2026 14:44
Widen the @workos-inc/node peer range to ^10.7.0 || ^11.0.0 || ^12.0.0 so apps on node 12 install without peer conflicts. authkit-session 0.9.1 already supports ^8 through ^12 and seals node 12's Date timestamps. Develop and test against node 12 (resolves to 12.2.0). Node 12 types user timestamps as Date, so two spec fixtures now use Date values.
nicknisi
force-pushed
the
nn/node-12-peer
branch
from
November 6, 2026 14:44
301a93e to
134ac67
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #131, which bumps
@workos/authkit-sessionto^0.9.1(the fix for sealing node 12 sessions, workos/authkit-session#69). Part of stack #133. Merge both withgh stack merge 132 --yes.Summary
@workos-inc/nodepeer range from^10.7.0to^10.7.0 || ^11.0.0 || ^12.0.0. Without this, apps that install node 12 get peer-dependency errors.^12.1.0, locked to 12.2.0), so CI covers the version customers are moving to.createdAt,updatedAtandlastSignInAtasDate, so two spec fixtures now useDatevalues. No source changes: user data reaches the client through TanStack server functions, and their serializer handlesDate.Verification (on node 12.2.0, pnpm 10)
typecheck,lint,format:check,build: passtest:coverage: 308/308 passexamplebuild andbuild:check: pass, no server fingerprints in the client bundle