Conversation
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Pull request overview
Fixes Zephyr Thumb-2 wolfSSL integration by aligning C preprocessor settings with the Thumb-2 assembly objects being built, and makes Zephyr benchmark/test entry points optionally accept argv-style arguments for more flexible benchmark selection.
Changes:
- Define Thumb-2-related wolfSSL ARM assembly macros in Zephyr user settings when
CONFIG_WOLFCRYPT_ARMASM_THUMB2is enabled. - Make
MAIN_NO_ARGSoptional on Zephyr via a newWOLFSSL_ZEPHYR_MAIN_ARGSopt-in.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
zephyr/user_settings.h |
Adds Thumb-2-specific #defines so C code matches the Thumb-2 asm ports chosen by Zephyr’s build. |
wolfssl/wolfcrypt/settings.h |
Gates MAIN_NO_ARGS behind a Zephyr-specific opt-in to allow argument parsing in benchmark/test entry points. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| * option parsing compiled in. */ | ||
| #ifndef WOLFSSL_ZEPHYR_MAIN_ARGS |
| * link fails. Matches what configure sets for --enable-armasm on a | ||
| * Thumb-2 target. */ | ||
| #define WOLFSSL_ARMASM_THUMB2 | ||
| #define WOLFSSL_ARMASM_NO_HW_CRYPTO |
| * link fails. Matches what configure sets for --enable-armasm on a | ||
| * Thumb-2 target. */ | ||
| #define WOLFSSL_ARMASM_THUMB2 | ||
| #define WOLFSSL_ARMASM_NO_HW_CRYPTO | ||
| #define WOLFSSL_ARM_ARCH 7 |
5b92ff9 to
7c1dc79
Compare
Description
This PR fixes broken Thumb-2 assembly integration in the wolfSSL module and relaxes main argument constraints for bench flexibility.
Key Changes
Testing
Tested on Toradex i.MX95 SMARC on real-time M7 core with Zephyr.
Checklist