Add SM cipher crypto cb paths - #10857
Open
padelsbach wants to merge 10 commits into
Open
padelsbach wants to merge 10 commits into
padelsbach wants to merge 10 commits into
Conversation
padelsbach
force-pushed
the
sm-crypto-cb
branch
2 times, most recently
from
August 12, 2026 04:51
d047c96 to
fc9c156
Compare
padelsbach
marked this pull request as ready for review
August 12, 2026 05:14
|
retest this please |
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #10857
Scan targets checked: wolfcrypt-bugs, wolfcrypt-port-bugs, wolfcrypt-rs-bugs, wolfcrypt-src, wolfssl-bugs, wolfssl-src
Findings: 9
9 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Findings are non-blocking.
padelsbach
commented
Aug 12, 2026
padelsbach
commented
Aug 12, 2026
padelsbach
commented
Aug 12, 2026
padelsbach
commented
Aug 12, 2026
padelsbach
commented
Aug 12, 2026
padelsbach
commented
Aug 12, 2026
padelsbach
commented
Aug 12, 2026
padelsbach
commented
Aug 12, 2026
padelsbach
commented
Aug 12, 2026
padelsbach
force-pushed
the
sm-crypto-cb
branch
from
August 12, 2026 19:06
fa69ddc to
1387db2
Compare
Contributor
Author
|
jenkins retest this please |
padelsbach
force-pushed
the
sm-crypto-cb
branch
3 times, most recently
from
August 24, 2026 20:45
5096a05 to
e744d1c
Compare
SparkiDev
requested changes
Aug 25, 2026
philljj
requested review from
philljj and
wolfSSL-Fenrir-bot
and removed request for
wolfSSL-Fenrir-bot
August 27, 2026 14:31
wolfSSL-Fenrir-bot
requested changes
Aug 30, 2026
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #10857
Scan targets checked: wolfcrypt-bugs, wolfcrypt-port-bugs, wolfcrypt-rs-bugs, wolfcrypt-src, wolfssl-bugs, wolfssl-src
Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Reported findings require changes before merge.
Contributor
|
Retest this please. (abort in PRB) |
padelsbach
force-pushed
the
sm-crypto-cb
branch
from
September 10, 2026 17:38
620869c to
7043914
Compare
Contributor
Author
|
retest this please |
padelsbach
force-pushed
the
sm-crypto-cb
branch
from
September 18, 2026 01:32
dcf31ac to
edbe50a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
NOTE: merge wolfSSL/wolfsm#34 first
Add the cryptocb functionality and plumbing for the SM algs.
Note that the wolfsm changes are needed for CI testing in wolfssl. Those will be added as follow-up PRs.
Testing
Added new test cases using swdev.
Checklist