zephyr: drop the dead wolfSSL feature options - #1265
Merged
Merged
Conversation
The sample configurations name their own wolfSSL settings file, so that header is authoritative and the feature options no longer resolve: wolfSSL gates them behind WOLFSSL_HAS_SETTINGS_FILE, and it has dropped the ALL_ENABLED symbols outright. Twister makes the resulting Kconfig warnings fatal, so all three scenarios failed to configure.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
All reviewed configurations consistently remove obsolete options with no unresolved issues.
Pull request overview
Removes obsolete wolfSSL Kconfig options from the three Zephyr sample configurations, preventing fatal configuration warnings.
Changes:
- Removes deprecated TLS 1.2 and
ALL_ENABLEDsymbols. - Preserves custom settings-header configuration.
File summaries
| File | Description |
|---|---|
zephyr/samples/tests/prj.conf |
Removes obsolete wolfSSL options. |
zephyr/samples/tests/prj_nofs.conf |
Removes obsolete wolfSSL options. |
zephyr/samples/tests/prj_kbi.conf |
Removes obsolete wolfSSL options. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
philljj
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wolfSSL's Zephyr Kconfig now gates every feature option behind
WOLFSSL_HAS_SETTINGS_FILE, which our sample configurations set by naming their own settings header, and it deleted theALL_ENABLEDsymbols outright. Twister makes the resulting Kconfig warnings fatal, so all three scenarios fail to configure on both matrix legs.CONFIG_WOLFSSL_TLS_VERSION_1_2and the fourALL_ENABLEDoptions from the three sample configurations-DWOLFSSL_SETTINGS_FILEalready makes our own header authoritativeBroken by wolfSSL PR 11401, merged 2026-09-18 17:56 UTC. The Zephyr workflow tracks wolfssl
master, so this hit every branch at once.