Fenrir Fix: Base64 stdin input is silently truncated at 8000 bytes - #286
aidankeefe2022 wants to merge 4 commits into
Conversation
1b35e33 to
556dc5a
Compare
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #286
Scan targets checked: wolfclu-bugs, wolfclu-src
Findings: 4
4 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Reported findings require changes before merge.
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #286
Scan targets checked: wolfclu-bugs, wolfclu-src
Findings: 2
2 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Reported findings require changes before merge.
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #286
Scan targets checked: wolfclu-bugs, wolfclu-src
Findings: 2
2 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Reported findings require changes before merge.
df9086c to
a022b83
Compare
a022b83 to
dc4ea63
Compare
fixed + hallucinations
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #286
Scan targets checked: wolfclu-src, wolfclu-bugs
Findings: 2
2 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Reported findings require changes before merge.
dc4ea63 to
d704e25
Compare
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #286
Scan targets checked: wolfclu-src, wolfclu-bugs
Findings: 2
2 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Reported findings require changes before merge.
d704e25 to
8b856ef
Compare
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #286
Scan targets checked: wolfclu-src, wolfclu-bugs
Findings: 3
3 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Reported findings require changes before merge.
Picking on future feature to allow wolfCLU to not need filesystem not in scope for this fix
added more tests for io for base64 and rewrote IO system for base64 looking to extend in the future
8b856ef to
bc07bd8
Compare
|
Planning on expanding this file interface to the rest of the codebase but for now starting with base64 |
a025563 to
dbeb34a
Compare
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #286
Scan targets checked: wolfclu-src, wolfclu-bugs
Findings: 2
2 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Reported findings require changes before merge.
dbeb34a to
423d36d
Compare
423d36d to
eae4ffe
Compare
Out of scope change
Added read/write io functions that can be used to interact with any file pointer
Fix for Fenrir finding : https://fenrir.wolfssl.com/finding/11088