Skip to content

test: cover ViewModel consumers and captured session observers - #5429

Draft
MohamadJaara wants to merge 2 commits into
refactor/metro-consumer-rebuildfrom
test/metro-consumer-regressions
Draft

MohamadJaara wants to merge 2 commits into
refactor/metro-consumer-rebuildfrom
test/metro-consumer-regressions

Conversation

@MohamadJaara

Copy link
Copy Markdown
Member

Stacks on #5426 and uses the SDK implementation from wireapp/kalium#4576. Moves the newly added regression coverage out of the Android implementation PR: 75 test methods, including ViewModel ownership and retention, real SDK repository identity, pending/revoked session observers, notification subscription ordering, failed startup cleanup and typed navigation restoration.

This layer changes tests and their dedicated persistence test dependency/substitution (+2,983/−8 across 23 files). The test tree matches the previously reviewed Android tip 5141bea, plus the preserved pre-existing assertEquals(4, events.size) check identified by split review. The implementation base retains the adaptations needed by pre-existing cases and the release-note fixture cleanup. The SDK pin continues to target the implementation layer; this PR does not require SDK test sources. No production code or generated API references are added.

Validation: the implementation base passed all 2,278 app unit tests; the restored test layer passed all 2,355 app tests. The final one-line cardinality correction then passed all nine tests in its class. Fresh independent closure review confirmed the preserved assertion and reported no remaining actionable split findings. The full app suite ran at the initial test tip; only the affected class was rerun after the final assertion correction. Navigation/KMP tests were not rerun for this packaging change. No Jira issue exists. This remains the approved three-read consumer slice; full ADR migration and performance measurements are outside this change.

@pull-request-size

Copy link
Copy Markdown

Ups 🫰🟨

This PR is too big. Please try to break it up into smaller PRs.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant