Repository navigation
test: cover ViewModel consumers and captured session observers - #5429
Draft
MohamadJaara wants to merge 2 commits into
Draft
MohamadJaara wants to merge 2 commits into
MohamadJaara wants to merge 2 commits into
Conversation
Ups 🫰🟨This PR is too big. Please try to break it up into smaller PRs. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacks on #5426 and uses the SDK implementation from wireapp/kalium#4576. Moves the newly added regression coverage out of the Android implementation PR: 75 test methods, including ViewModel ownership and retention, real SDK repository identity, pending/revoked session observers, notification subscription ordering, failed startup cleanup and typed navigation restoration.
This layer changes tests and their dedicated persistence test dependency/substitution (+2,983/−8 across 23 files). The test tree matches the previously reviewed Android tip
5141bea, plus the preserved pre-existingassertEquals(4, events.size)check identified by split review. The implementation base retains the adaptations needed by pre-existing cases and the release-note fixture cleanup. The SDK pin continues to target the implementation layer; this PR does not require SDK test sources. No production code or generated API references are added.Validation: the implementation base passed all 2,278 app unit tests; the restored test layer passed all 2,355 app tests. The final one-line cardinality correction then passed all nine tests in its class. Fresh independent closure review confirmed the preserved assertion and reported no remaining actionable split findings. The full app suite ran at the initial test tip; only the affected class was rerun after the final assertion correction. Navigation/KMP tests were not rerun for this packaging change. No Jira issue exists. This remains the approved three-read consumer slice; full ADR migration and performance measurements are outside this change.