Skip to content

Drop unused raw input registration on Windows #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
twlite merged 1 commit into from
Sep 23, 2026
Merged

Drop unused raw input registration on Windows #56

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/app.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ use napi::Result;
use napi_derive::napi;
use tao::{
event::{ElementState, MouseButton, MouseScrollDelta, TouchPhase, WindowEvent},
event_loop::EventLoop,
event_loop::{DeviceEventFilter, EventLoop},
keyboard::{Key, KeyCode, ModifiersState},
window::WindowId,
};
Expand Down Expand Up @@ -743,6 +743,11 @@ impl Application {
pub fn new(env: Env, _options: Option<ApplicationOptions>) -> Result<Self> {
let event_loop = EventLoop::new();

// Nothing here ever consumes a tao DeviceEvent (the pump closure drops
// them), so leaving raw input registered is pure cost - on Windows it
// delayed input into the WebView2 child by seconds while a key was held.
event_loop.set_device_event_filter(DeviceEventFilter::Always);

// On macOS install a default app menu immediately so the menu bar is
// functional from the start. Store it in global_menu so the ObjC delegate
// is kept alive (it would be freed if the Menu were dropped here).
Expand Down
Loading