Repository navigation
Conversation
Upstream renamed the Windows NSIS installer to include an architecture suffix starting with 2.1.0 (Openscreen.Setup.<version>-<arch>.exe) and stopped publishing the arch-less Openscreen.Setup.<version>.exe. The provider therefore resolved a 404 URL on Windows, failing the provider matrix and turning the required CI Success gate red on main. Select the arch-suffixed installer for 2.1.0+ (x64 and arm64) and keep the arch-less x64 name for the 2.0.x line, which only ever shipped a single x64 installer. Extend the provider tests to cover both naming schemes and update the platform docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Upstream
getopenscreen/openscreenrenamed its Windows NSIS installer to include an architecture suffix starting with2.1.0(Openscreen.Setup.<version>-<arch>.exe) and no longer publishes the arch-lessOpenscreen.Setup.<version>.exe. The provider still built the arch-less name, so on Windows it requested a URL that returns HTTP 404:This fails the Windows provider matrix, which aggregates into the required
CI Successgate, so any PR based onmaincannot merge while this asset name is stale.Fix
Openscreen.Setup.<version>-<arch>.exefor versions>= 2.1.0, for bothx64andarm64.2.0.xline only ever published a single arch-less x64 installer, so that name is kept for2.0.x(x64 only); requesting2.0.0on arm64 still yields no URL instead of fabricating one.Verified against upstream releases:
.../v2.1.1/Openscreen.Setup.2.1.1-x64.exeand.../v2.1.1/Openscreen.Setup.2.1.1-arm64.exeresolve (HTTP 200), as does the legacy.../v2.0.0/Openscreen.Setup.2.0.0.exe.Tests
crates/vx-cli/tests/openscreen_provider_tests.rsto cover both naming schemes (x64/arm64 at2.1.0/2.1.1, plus the legacy arch-less2.0.0); all cases pass locally.2.1.0.