Repository navigation
fix(deps): patch four compatible locked dependencies - #1227
Merged
Merged
Conversation
loonghao
force-pushed
the
fix/compatible-security-lock-patches
branch
from
October 16, 2026 06:06
a68dfa1 to
82114f3
Compare
loonghao
marked this pull request as ready for review
October 17, 2026 07:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Apply four compatible patch updates to the committed Cargo.lock, without regenerating the lockfile or changing package manifests:
The entire diff is 16 lines: four version/checksum pairs. Every other package field and dependency edge is unchanged, including the existing Windows bindings. Checksums are Cargo-generated and independently matched against the official crates.io index; all four selected versions are not yanked.
Verification
5a85987d9c77a73a0e67f9141d1df19a5ad8ac06. Now rebased ontoed367264c6c91c3c565b2815881aec3cb2c0c482after fix(archive): validate 7z entry paths before extraction #1226 merged; current head82114f3b9cb5613fef4f2fab70c3a80c740c0e25. The same 16-line Cargo.lock-only diff is preserved.vx cargo metadata --locked --offline --format-version 1 --filter-platform x86_64-unknown-linux-gnu: passed; Cargo.lock was not modified.vx git diff --check: passed.dff420534c64eba856804ad49036002e8215bc87c1202ca9391206b3cfeeca2b.Audit result and remaining work
Both exact committed baseline and candidate locks were audited without regeneration using cargo-audit 0.22.2, the same RustSec database commit
edb58f5974b83eb8302332821cb6d389777aa351, and--no-fetch --deny warnings --format json.This is a bounded improvement, not a clean security audit. Existing CI audit recipes swallow command failures and may try to regenerate the lockfile; their green status is not evidence of an audit pass. Correct failure propagation and remaining dependency migrations need separate work. No advisory exclusions, audit settings, workflow permissions, or release settings are changed.
Related archive path hardening and integration test repairs remain in #1226. This PR is intentionally separate and stays draft until independent review and exact-head CI verification.
Original-branch CI and rebased validation
a68dfa1252c67423395e89113839b526ceddd1c9completed 36 successful checks and 18 conditional skips. Linux, Windows, macOS x86_64, and macOS ARM64 release builds each compiled the four patched versions successfully, with no lock reselection reported.Rebased validation verified on 2026-10-17
82114f3b9cb5613fef4f2fab70c3a80c740c0e25; base remainsed367264c6c91c3c565b2815881aec3cb2c0c482. The CI checkout is GitHub's test merge33b9ebd675a2b6f0361a27b2a20be9cf6d4cb288; it has the identical Git tree5e2df5fe80d4119aa1d373a8026cc2e3ae007cbfas the PR head, verified from both commit objects.no operations to perform, and formatting, Clippy and Rust documentation completed. Its existing advisory inline-test check still prints a failure that the workflow suppresses; this is not represented as a strict all-quality-gates pass.zip ^8.1release is yanked. Both failures are swallowed by the existing recipe, so the green job is not a clean audit.The prior pending native-test and generated-hakari checks are now resolved. This PR remains Draft; remaining dependency migrations and truthful audit failure propagation are separate work. No merge, release, permission change or advisory exclusion was performed.
Strict audit of merged main — 2026-10-17 08:03 UTC
The compatible lock patches in #1227 are now merged as
0388b75a24f28b376c5372c95a4d064ffdd581df. A separate read-only audit of that exact committed lock reports 11 vulnerabilities and 7 denied warnings, with exit code 1.7fb9497f8594b389e5fce5ef9b92db08432996895b2e0c5a0167a69ed445c428, verified before execution.bffb70410116a0e4dc754fcbe32559bc009c8e40, SHA256dff420534c64eba856804ad49036002e8215bc87c1202ca9391206b3cfeeca2b. The blob matches merged main and its bytes were unchanged after both JSON and terminal audits.cargo-audit audit --deny warnings --file Cargo.lock --db advisory-db --json; terminal confirmation used the same database with--no-fetch. No ignore, target filtering, lock regeneration or dependency update was used.64f92cdc64401fab47baa10e2e11fe382aa57155, 1334 advisories.Dependency remediation remains outstanding. The audit-gate fix in #1228 remains Draft and blocked by its failed required CI Success check; no protection or permission changes, bypass, or merge of #1228 was performed.