Repository navigation
Conversation
Two independent dependency blockers, each gating a queued renovate bump. async-trait 0.1.89 emits a redundant #[must_use] on the boxed future returned by every #[async_trait] method. clippy 1.99.0 adds double_must_use, which under -D warnings fails Code Quality at crates/vx-ecosystem-pm/src/traits.rs:17 and crates/vx-versions/src/fetch_context.rs:12. 0.1.92 drops the redundant attribute, so the lint no longer fires and no allow is needed. tracing-opentelemetry 0.34.0 builds against opentelemetry 0.33.0 while this repo pins the monorepo below 0.33.0, so taking that bump on its own splits the graph: vx-metrics matches an opentelemetry 0.32 SdkTracer against the opentelemetry 0.33 Tracer bound in OpenTelemetryLayer::with_tracer (E0277, then E0599 on with_filter). Cap tracing-opentelemetry below 0.34.0 next to the existing monorepo cap and lift both together when the monorepo is ready to move.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
Two independent dependency blockers, each gating a queued renovate bump. They share no code path, but both must clear before the renovate queue can drain.
1.
async-trait0.1.89 -> 0.1.92 — unblockschore(deps): update rust to v1.99.0clippy1.99.0 adds thedouble_must_uselint.async-trait0.1.89 emits a redundant#[must_use]on the boxed future returned by every#[async_trait]method, so under-D warningstheCode Quality (via vx)job fails:Reproduced locally with
cargo +1.99.0 clippy -p vx-ecosystem-pm -p vx-versions --all-targets -- -D warnings -Aasync-fn-in-trait: 1 error invx-ecosystem-pmand 2 invx-versions, matching CI exactly.async-trait0.1.92 drops the redundant attribute, so the lint no longer fires. No#[allow]is needed, which keeps the lint working where it is a real signal.2. renovate: cap
tracing-opentelemetrybelow 0.34.0tracing-opentelemetry0.34.0 builds againstopentelemetry0.33.0, while this repo already pins the opentelemetry monorepo below 0.33.0 (added in #1127). Taking thetracing-opentelemetrybump on its own splits the dependency graph:That breaks
Build vxon every platform, plusBuild vx binary,Benchmark,Analyze (CodeQL via vx)andDocker Success.This adds a
tracing-opentelemetrycap next to the existing monorepo cap and refreshes the stale rationale on the monorepo rule, which still described 0.33.0 as the newesttracing-opentelemetryrelease. Both caps should be lifted together when the monorepo is ready to move to 0.33.With the cap in place renovate stops proposing the bump, so PR #1158 can be closed rather than fixed.
Verification
cargo +1.99.0 clippy -p vx-ecosystem-pm -p vx-versions --all-targets -- -D warnings -Aasync-fn-in-trait— exit 0 (was exit 101 with 3 errors)cargo check --workspace --all-targets— exit 0renovate.jsonparses as valid JSONsyn 2.0.119tosyn 3.0.6, both already presentNotes
async-traitlockfile bump in chore(deps): update rust crate async-trait to v0.1.92 #1043, which makes the same change.Test (Linux-x86_64) - Fullon thenode/cross_toole2e groups. That is a separate, environmental cause already fixed onmainby fix: harden 7z path-traversal test and preinstall Node on Linux CI #1216 (preinstall Node on Linux CI) and the e2e process-capture fix; those branches need a rebase, not a code change. A plain CI re-run will not help them, because the fix lives in.github/workflows/ci.ymlrather than in the product code.Security follow-up (2026-10-16)
rustlslock entry from 0.23.45 to 0.23.46; this follow-up changes only its version and registry checksum, with the dependency graph unchanged. Current head:40eee51c4e96f4467c95e62d7975abcb642d91e7.