Repository navigation
chore(deps): update rust crate test-case to v3.4.0 - #1160
Open
renovate[bot] wants to merge 2 commits into
Open
renovate[bot] wants to merge 2 commits into
renovate[bot] wants to merge 2 commits into
Conversation
renovate
Bot
force-pushed
the
renovate/test-case-3.x-lockfile
branch
2 times, most recently
from
October 6, 2026 15:31
8bf8fad to
8249fd6
Compare
loonghao
force-pushed
the
renovate/test-case-3.x-lockfile
branch
from
October 14, 2026 02:32
8249fd6 to
013680c
Compare
…file The Windows full job failed `test_sfx_rejects_paths_outside_destination` with `Access is denied. (os error 5)` where the test expected the `Unsafe path` rejection. The path guard is not what failed: every error raised inside the 7z extractor is wrapped as `Failed to extract 7z archive: ...`, and the reported message carried no such prefix, so it came from the setup that runs before the guard ever sees an entry name - `create_dir_all`, the signature scan, or `open_sevenz_payload`. The same test passed the Windows full job on the two adjacent `main` heads, so the rejection itself was never Windows-specific. `open_sevenz_payload` was the fragile part of that setup: it reopened the archive to scan the 4 MiB prefix a second time, then copied the entire payload into an unnamed temporary file in the process-wide temp directory, which every other test in the workspace and the CI runner itself also write to. For a multi-hundred-MiB installer that copy is also pure overhead. - Reuse the signature offset that format detection already found, so the prefix is scanned once per extraction instead of twice. - Read the payload through a bounded `Read + Seek` window over the already open file, so no temp file is created and the payload is never duplicated. - Name the path in the remaining setup errors, so a filesystem failure can no longer be reported as an archive that was not rejected. The traversal assertions are unchanged: all five unsafe-path inputs are still rejected by `safe_sevenz_entry_path` on Windows.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
3.3.1→3.4.0Release Notes
frondeus/test-case (test-case)
v3.4.0Compare Source
Changes
Instead of having a conflict in example like this:
It now generates prefix name for each test case. In all cases:
Generates
assert_eq!(result, expectation)instead of previousassert_eq!(expectation, result);Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.