Tkakar/fix 519 - #520
Open
tkakar wants to merge 4 commits into
Open
Tkakar/fix 519#520tkakar wants to merge 4 commits into
tkakar wants to merge 4 commits into
Conversation
tkakar
requested review from
keller-mark
and removed request for
keller-mark
September 18, 2026 12:58
tkakar
commented
Sep 18, 2026
|
|
||
| return e('div', { ref: divRef, style: { height: height + 'px' } }, | ||
| e(React.Suspense, { fallback: e('div', {}, 'Loading...') }, | ||
| e(React.StrictMode, {}, |
Collaborator
Author
There was a problem hiding this comment.
@keller-mark can you please confirm if it's not going to be an issue for other views?
I tested a few notebooks with widget() and they were working fine.
tkakar
force-pushed
the
tkakar/fix-519
branch
from
September 18, 2026 13:46
9698691 to
97d83b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
React strictModeto avoid multiple initial mounts of Neuroglancer causing a race condition between it's different RPCs.This removes the error messages reported in #517 but the loading overlay is still not going away -- pending further investigation.