Repository navigation
Initialize request context for exempt methods in verify_jwt_in_request - #585
Open
saiyam-jain-dev wants to merge 1 commit into
Open
saiyam-jain-dev wants to merge 1 commit into
saiyam-jain-dev wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #475
Description
When a request method is in
config.exempt_methods(default:['OPTIONS']),verify_jwt_in_request()previously returnedNoneimmediately without populatingg._jwt_extended_jwtor related context keys. When view handlers or@app.before_requesthooks accessedget_jwt_identity(),get_jwt(), orcurrent_user, aRuntimeErrorwas raised saying@jwt_required()was not called even though the endpoint was decorated.In addition, when
optional=Truewas used on an exempt method, it short-circuited rather than decoding any token present in the request or safely defaulting when no token was provided.This PR:
g._jwt_extended_jwt = {},g._jwt_extended_jwt_header = {}, andg._jwt_extended_jwt_user = {"loaded_user": None}when short-circuiting on exempt methods soget_jwt_identity()returnsNoneinstead of raising aRuntimeError.optional=True, allowing any passed JWT to be decoded while falling back cleanly toNoneif no authorization header is present.OPTIONSrequests on both required and optional endpoints.