Repository navigation
Accept borrowing vtable entries in inheritance codegen tests - #802
Merged
Merged
Conversation
Virtual slots whose implementations all borrow a parameter now store the borrowing body (`@sc_bf_...`), or a virtual adapter, instead of the owned entry (`@sc_f_...`). Three inheritance codegen tests still required the owned entry. They now accept either entry for the same implementation, so they keep checking which method fills each slot. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tests/harness/inheritance.test.tsfails on main in three tests that pin vtable contents. When every implementation of a virtual slot borrows a parameter, the vtable now stores that implementation's borrowing body (@sc_bf_…) or its virtual adapter instead of the owned entry (@sc_f_…). These tests still required the owned spelling.inheritance.test.ts: 7/7 pass. Lint and format are clean.🤖 Generated with Claude Code