Repository navigation
Conversation
…and array projections" (#799) With #799 the self-hosted compiler can no longer lower LlEmitter: building the native CLI fails with SC1090 ("constructing through a class value whose class has no lowering") and no diagnostic for the class itself, which breaks the bootstrap-seed builds. inheritance.test.ts also still expected owned vtable entries after the virtual-borrowing change. More than one of its commits trips the self-hosted subset, so revert the whole PR to get main green; the changes will be re-landed one by one with the native bootstrap checked for each.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
|
Fixed in #801 |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #799 to get main green again.
After #799, main's CI fails in two ways:
LlEmitter. Building the native CLI (packages/compiler/src/native/cli.ts) fails withSC1090: constructing through a class value whose class has no lowering, and no diagnostic is ever reported for the class itself (a separate scriptc reporting bug). Bisecting tsc-ts -5%: borrow field-store receivers, virtual parameters and array projections #799's commits: the first one that breaks it is "Borrow parameters that every implementation of a virtual method borrows", but reverting only that one is not enough, so more than one commit trips the self-hosted subset.tests/harness/inheritance.test.ts: three tests still expect owned vtable entries (@sc_f_…) where virtual-slot borrowing now stores the borrowing body.The resulting tree is identical to #795's tip. Checked locally: the native CLI frontend compiles with no diagnostics, and
inheritance.test.tsplusself-hosting-emission.test.tspass.#799's changes (~5% on the tsc-ts self-check) will be re-landed commit by commit, with the native bootstrap and the inheritance tests checked for each, together with a fix for the missing class diagnostic.