Repository navigation
fix(isTaxID, isIdentityCard): accept the 2023 Finnish century signs - #2948
Open
shaurya703 wants to merge 1 commit into
Open
shaurya703 wants to merge 1 commit into
shaurya703 wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2948 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 114 114
Lines 2599 2599
Branches 658 658
=========================================
Hits 2599 2599 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since 1 January 2023 the Finnish personal identity code (henkilötunnus) can use more century signs:
-,Y,X,W,V,Ufor people born in the 1900s andA,B,C,D,E,Ffor people born in the 2000s.+is still used for the 1800s.isTaxID(str, 'fi-FI')andisIdentityCard(str, 'FI')only accept-,+andA, so they reject valid codes that use the new signs:Both codes have correct check characters (
010594902 % 31 = 1,020502902 % 31 = 29 -> X).Changes:
isTaxID(fi-FI): the format regex now accepts[-+A-FU-Y]as the century sign.fiFiCheckmapsU–Yto the 1900s along with-, so the birth date check uses the right century. For example,290200Y1239is still rejected because 29 Feb 1900 did not exist, and290200A1239(29 Feb 2000) is accepted.isIdentityCard(FI): the format regex accepts the same set of signs. This validator does not check the date, so nothing else changes.Tests: added
010594Y9021and020502E902Xas valid cases for both validators, plus290200A1239(valid) and290200Y1239(invalid) forisTaxIDand an unknown sign (G) as invalid forisIdentityCard. Onmasterthe new valid cases fail; with this changenpm testpasses (323 passing, 100% coverage).Reference: https://dvv.fi/en/personal-identity-code
Checklist