Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2945 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 114 114
Lines 2599 2599
Branches 658 658
=========================================
Hits 2599 2599 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benin moved from 8-digit to 10-digit phone numbers on 30 November 2024: every number got the
01prefix, and 8-digit numbers stopped working when the parallel-running period ended on 29 December 2024.The
fr-BJrule (/^(\+229)\d{8}$/) still expects 8 digits. As a result,isMobilePhonerejects every current Beninese mobile number, such as+2290197123456, and accepts 8-digit numbers that no longer exist.This PR:
01followed by the mobile ranges, using the same pattern as Google libphonenumber's BJ mobile metadata:01(2[5-9]|[4-69]\d)\d{6};0120–0124;+229mandatory, as before;+22920…to+22923…, were fixed-line numbers;+.The ITU table lists
0125–0129as "fixed and mobile" series. Google classifies them as fixed-line-or-mobile and includes them in its mobile pattern, so this PR accepts them too.References
Checklist