Repository navigation
fix(isDivisibleBy): preserve integer divisors in exponent notation - #2939
Open
LucasLeao18 wants to merge 1 commit into
Open
LucasLeao18 wants to merge 1 commit into
LucasLeao18 wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2939 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 114 114
Lines 2599 2600 +1
Branches 658 659 +1
=========================================
+ Hits 2599 2600 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isDivisibleBy('1', 1e21)currently returnstrue:parseIntconverts the numeric divisor to"1e+21"and truncates it to 1. Convert the divisor withNumberand require an integer before applying the remainder operation. Large integer divisors then retain their value, while fractional, zero and non-finite divisors returnfalse.This follows the preference for integer divisors discussed in #1349 and #1350; it does not introduce approximate decimal divisibility. The README now states the divisor contract.
Validation on Node 24.15.0 / Windows:
npm test: 325 passed, including build and lint; 100% line coverage.Checklist
Prepared with OpenAI Codex; tests were run locally.