Skip to content

fix(isStrongPassword): count repeated supplementary characters correctly #2930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FanWu-ai wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(isStrongPassword): count repeated supplementary characters correctly #2930

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/lib/isStrongPassword.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,14 @@ function analyzePassword(password) {
let analysis = {
length: password.length,
uniqueChars: Object.keys(charMap).length,
repeatedChars: 0,
uppercaseCount: 0,
lowercaseCount: 0,
numberCount: 0,
symbolCount: 0,
};
Object.keys(charMap).forEach((char) => {
analysis.repeatedChars += charMap[char] - 1;
/* istanbul ignore else */
if (upperCaseRegex.test(char)) {
analysis.uppercaseCount += charMap[char];
Expand All @@ -66,7 +68,7 @@ function analyzePassword(password) {
function scorePassword(analysis, scoringOptions) {
let points = 0;
points += analysis.uniqueChars * scoringOptions.pointsPerUnique;
points += (analysis.length - analysis.uniqueChars) * scoringOptions.pointsPerRepeat;
points += analysis.repeatedChars * scoringOptions.pointsPerRepeat;
if (analysis.lowercaseCount > 0) {
points += scoringOptions.pointsForContainingLower;
}
Expand Down
60 changes: 60 additions & 0 deletions test/sanitizers.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,6 +283,66 @@ describe('Sanitizers', () => {
});
});

it('should score passwords with unique supplementary characters', () => {
test({
sanitizer: 'isStrongPassword',
args: [{ returnScore: true }],
expect: {
'😀': 1,
'😀😁': 2,
'Aa1!😀': 45,
},
});
});

it('should score passwords with repeated supplementary characters', () => {
test({
sanitizer: 'isStrongPassword',
args: [{ returnScore: true }],
expect: {
'😀😀': 1.5,
'😀😁😀': 2.5,
'Aa1!😀😀': 45.5,
},
});
});

it('should score passwords with custom supplementary character points', () => {
test({
sanitizer: 'isStrongPassword',
args: [{
returnScore: true,
pointsPerUnique: 3,
pointsPerRepeat: 2,
pointsForContainingLower: 7,
pointsForContainingUpper: 11,
pointsForContainingNumber: 13,
pointsForContainingSymbol: 17,
}],
expect: {
'😀': 3,
'😀😀': 5,
'😀😁😀': 8,
'Aa1!😀😀': 65,
},
});
});

it('should preserve password scoring for BMP characters and lone surrogates', () => {
test({
sanitizer: 'isStrongPassword',
args: [{ returnScore: true }],
expect: {
'': 0,
é: 1,
éé: 1.5,
'\uD83D': 1,
'\uDE00': 1,
'\uD83D\uD83D': 1.5,
},
});
});

it('should score passwords with default options', () => {
test({
sanitizer: 'isStrongPassword',
Expand Down