Skip to content

intel mac compatibility - #378

Merged
uvcat7 merged 3 commits into
uvcat7:betafrom
sukibaby:intel-mac-test
Oct 30, 2026
Merged

uvcat7 merged 3 commits into
uvcat7:betafrom
sukibaby:intel-mac-test

Conversation

@sukibaby

@sukibaby sukibaby commented Oct 30, 2026 •

Copy link
Copy Markdown
Collaborator

allows building on the majority of macOS Intel hardware. Would allow us to provide an Intel Mac release that is usable on more than just Tahoe (macOS 26, same as macos-latest runner)

Sticking with jthread would restrict the macOS Intel build to specifically macOS 26. jthread is only available in macOS Tahoe so it is replaced with the standard c++17 plain ol thread to allow building & running on Intel Macs.

also define climits via system.h since older apple compiler might need this defined.

Tested on both an old Retina MacBook Pro on macOS 15 as well as an Apple Silicon machine running macOS 26.

allows building on the majority of macOS Intel hardware. jthread is only available in macOS Tahoe. also define climits via system.h since older apple compiler might need this defined
@sukibaby

Copy link
Copy Markdown
Collaborator Author

Not sure what's up with these CI failures but they do not seem to be related to the PR

Screenshot 2026-10-30 at 12 45 43 AM

@uvcat7

uvcat7 commented Oct 30, 2026

Copy link
Copy Markdown
Owner

The CI failures are the package caching not working since you're doing the build on your own repo. I tried to fix it but the fix is clearly not working.

@uvcat7
uvcat7 merged commit 63701bf into uvcat7:beta Oct 30, 2026
4 of 8 checks passed
@sukibaby
sukibaby deleted the intel-mac-test branch October 30, 2026 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants