Repository navigation
intel mac compatibility - #378
Merged
Merged
Conversation
allows building on the majority of macOS Intel hardware. jthread is only available in macOS Tahoe. also define climits via system.h since older apple compiler might need this defined
Collaborator
Author
Owner
|
The CI failures are the package caching not working since you're doing the build on your own repo. I tried to fix it but the fix is clearly not working. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

allows building on the majority of macOS Intel hardware. Would allow us to provide an Intel Mac release that is usable on more than just Tahoe (macOS 26, same as
macos-latestrunner)Sticking with jthread would restrict the macOS Intel build to specifically macOS 26. jthread is only available in macOS Tahoe so it is replaced with the standard c++17 plain ol thread to allow building & running on Intel Macs.
also define climits via system.h since older apple compiler might need this defined.
Tested on both an old Retina MacBook Pro on macOS 15 as well as an Apple Silicon machine running macOS 26.