Repository navigation
fix(mover): use a widely supported arrow for the Mover direction label - #2705
Junker der Provinz (junkerderprovinz) wants to merge 2 commits into
Conversation
WalkthroughThe Share settings mover direction dropdown replaces the ChangesMover Direction Labels
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. > A bunny hops through settings bright, Comment |
|
Small ping on this one. It swaps U+2B95 for U+2192 in the Mover direction labels in ShareEdit.page, which is the tofu box in #2545, open since February. Six lines in one file and CodeRabbit found nothing; happy to rebase, or close it if you'd rather fix this on the font side. |
Co-authored-by: DelPoint <1571585+DelPoint@users.noreply.github.com>
🔧 PR Test Plugin AvailableA test plugin has been generated for this PR that includes the modified files. Version: 📥 Installation Instructions:Install via Unraid Web UI:
Alternative: Direct Download
|
Fixes #2545.
The Mover direction options in Share Settings use
⮕(U+2B95), which is missing from many system fonts and renders as a tofu box. Replacing it with→(U+2192), which is universally available, keeps the same meaning and renders everywhere.The label is set via jQuery
.text(), so a literal character is used rather than an HTML entity.Summary by CodeRabbit