Skip to content

fix(mover): use a widely supported arrow for the Mover direction label - #2705

Open
Junker der Provinz (junkerderprovinz) wants to merge 2 commits into
unraid:masterfrom
junkerderprovinz:fix/mover-direction-arrow
Open

Junker der Provinz (junkerderprovinz) wants to merge 2 commits into
unraid:masterfrom
junkerderprovinz:fix/mover-direction-arrow

Conversation

@junkerderprovinz

@junkerderprovinz Junker der Provinz (junkerderprovinz) commented Jul 27, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #2545.

The Mover direction options in Share Settings use ⮕ (U+2B95), which is missing from many system fonts and renders as a tofu box. Replacing it with → (U+2192), which is universally available, keeps the same meaning and renders everywhere.

The label is set via jQuery .text(), so a literal character is used rather than an HTML entity.

Summary by CodeRabbit

  • Style
    • Updated the “Mover action” direction indicator to use a simpler arrow symbol for improved visual consistency.

@coderabbitai

coderabbitai Bot commented Jul 27, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

The Share settings mover direction dropdown replaces the ⮕ glyph with → across the affected transfer scenarios in updateScreen().

Changes

Mover Direction Labels

Layer / File(s) Summary
Update mover direction labels
emhttp/plugins/dynamix/ShareEdit.page
Mover direction option labels use the → glyph in all affected transfer and preference branches.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: replacing the Mover arrow with a widely supported character.
Linked Issues check ✅ Passed The PR replaces the illegible ⮕ glyph with → in Share Settings, satisfying #2545's direction-label fix.
Out of Scope Changes check ✅ Passed The change is narrowly scoped to the ShareEdit.page arrow label and adds no unrelated behavior.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

> A bunny hops through settings bright,
> Replacing arrows left and right.
> The mover’s path is clear to see,
> With → guiding happily.
> Carrots cheer: “A neat UI!”

Comment @coderabbitai help to get the list of available commands.

@junkerderprovinz

Copy link
Copy Markdown
Contributor Author

Small ping on this one. It swaps U+2B95 for U+2192 in the Mover direction labels in ShareEdit.page, which is the tofu box in #2545, open since February. Six lines in one file and CodeRabbit found nothing; happy to rebase, or close it if you'd rather fix this on the font side.

@unraid-bot Unraid Bot (unraid-bot) added the QA Blocked QA blocked (auto-managed by notification-worker) label Sep 4, 2026
Co-authored-by: DelPoint <1571585+DelPoint@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown

🔧 PR Test Plugin Available

A test plugin has been generated for this PR that includes the modified files.

Version: 2026.10.16.0119
Build: View Workflow Run

📥 Installation Instructions:

Install via Unraid Web UI:

  1. Go to Plugins → Install Plugin
  2. Copy and paste this URL:
https://preview.dl.unraid.net/pr-plugins/pr-2705/webgui-pr-2705.plg
  1. Click Install

Alternative: Direct Download

⚠️ Important Notes:

  • Testing only: This plugin is for testing PR changes
  • Backup included: Original files are automatically backed up
  • Easy removal: Files are restored when plugin is removed
  • Conflicts: Remove this plugin before installing production updates
  • Post-merge behavior: This preview stays available after merge until preview storage expires or it is manually cleaned up

📝 Modified Files:

Click to expand file list
emhttp/plugins/dynamix/ShareEdit.page

🔄 To Remove:

Navigate to Plugins → Installed Plugins and remove webgui-pr-2705, or run:

plugin remove webgui-pr-2705

🤖 This comment is automatically generated and will be updated with each new push to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

QA Blocked QA blocked (auto-managed by notification-worker)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mover Action Direction in Share Settings: illegible character to indicate the direction of Mover's action

2 participants