Skip to content

fix(settings): omit internal provider values - #2096

Open
SimonFair wants to merge 6 commits into
mainfrom
codex/settings-data
Open

SimonFair wants to merge 6 commits into
mainfrom
codex/settings-data

fix: prefer provider ids

acf61be
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 30, 2026 in 0s

53.39% (+0.01%) compared to d4d9733

View this Pull Request on Codecov

53.39% (+0.01%) compared to d4d9733

Details

Codecov Report

❌ Patch coverage is 69.01408% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.39%. Comparing base (d4d9733) to head (acf61be).

Files with missing lines Patch % Lines
...pi/graph/resolvers/sso/core/oidc-config.service.ts 58.06% 13 Missing ⚠️
...-api/graph/resolvers/settings/settings.resolver.ts 70.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2096      +/-   ##
==========================================
+ Coverage   53.38%   53.39%   +0.01%     
==========================================
  Files        1044     1044              
  Lines       72705    72762      +57     
  Branches     8399     8420      +21     
==========================================
+ Hits        38811    38853      +42     
- Misses      33767    33782      +15     
  Partials      127      127              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.