Skip to content

chore(github): stop requiring signed commits on main - #275

Merged
UnstoppableMango merged 1 commit into
mainfrom
chore/drop-required-signatures
Sep 29, 2026
Merged

UnstoppableMango merged 1 commit into
mainfrom
chore/drop-required-signatures

Conversation

@UnstoppableMango

@UnstoppableMango UnstoppableMango commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Squash is the only merge method, so every commit on main is one GitHub creates and signs with its web-flow key. The rule only blocked merging PRs whose own commits were unsigned, which a GitHub App (Claude) and most external contributors cannot sign, and which squashing discards.

Summary by CodeRabbit

  • Changes
    • Main branch rulesets no longer require signed commits.

Squash is the only merge method, so every commit on main is one GitHub
creates and signs with its web-flow key. The rule only blocked merging
PRs whose own commits were unsigned, which a GitHub App (Claude) and
most external contributors cannot sign, and which squashing discards.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@UnstoppableMango
UnstoppableMango enabled auto-merge (squash) September 29, 2026 00:40
@coderabbitai

coderabbitai Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 67816778-6517-40e2-998b-37f635a2a043

📥 Commits

Reviewing files that changed from the base of the PR and between 123b538 and 5c5afc5.

📒 Files selected for processing (1)
  • components/publicRepo.ts
💤 Files with no reviewable changes (1)
  • components/publicRepo.ts

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The main branch ruleset no longer requires commit signatures.

Changes

Main branch rules

Layer / File(s) Summary
Remove required signatures
components/publicRepo.ts
The main ruleset no longer sets requiredSignatures to true.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 5c5af

The change permits unsigned PR commits while retaining the configured squash-merge workflow. No established issue prevents merging after normal checks.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: removing the requirement for signed commits on the main branch.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@UnstoppableMango
UnstoppableMango merged commit cf588a0 into main Sep 29, 2026
5 checks passed
@UnstoppableMango
UnstoppableMango deleted the chore/drop-required-signatures branch September 29, 2026 00:57
@pulumi

pulumi Bot commented Sep 29, 2026

Copy link
Copy Markdown

🍹 The Update (preview) for UnstoppableMango/unmango-github/prod (at 5c5afc5) was successful.

Resource Changes

    Name                        Type                                              Operation
~   protofs                     github:index/repositoryRuleset:RepositoryRuleset  update
~   strata                      github:index/repositoryRuleset:RepositoryRuleset  update
~   thecluster                  github:index/repositoryRuleset:RepositoryRuleset  update
~   containers                  github:index/repositoryRuleset:RepositoryRuleset  update
~   actions                     github:index/repositoryRuleset:RepositoryRuleset  update
~   terraform-provider-atproto  github:index/repositoryRuleset:RepositoryRuleset  update
~   kubebuilder-nix             github:index/repositoryRuleset:RepositoryRuleset  update
~   go                          github:index/repositoryRuleset:RepositoryRuleset  update
~   pkgs                        github:index/repositoryRuleset:RepositoryRuleset  update
~   thecluster-operator         github:index/repositoryRuleset:RepositoryRuleset  update
~   pulumipkgs                  github:index/repositoryRuleset:RepositoryRuleset  update
~   palworld-operator           github:index/repositoryRuleset:RepositoryRuleset  update
~   terraform2crd               github:index/repositoryRuleset:RepositoryRuleset  update
~   pulumi-baremetal            github:index/repositoryRuleset:RepositoryRuleset  update
~   cloudflare-operator         github:index/repositoryRuleset:RepositoryRuleset  update
~   nix2git                     github:index/repositoryRuleset:RepositoryRuleset  update
~   terraform-provider-netgear  github:index/repositoryRuleset:RepositoryRuleset  update
~   slip                        github:index/repositoryRuleset:RepositoryRuleset  update
~   kubebuilder                 github:index/repositoryRuleset:RepositoryRuleset  update
~   go-pia                      github:index/repositoryRuleset:RepositoryRuleset  update
~   gnumake-go                  github:index/repositoryRuleset:RepositoryRuleset  update
~   tfpkgs                      github:index/repositoryRuleset:RepositoryRuleset  update
~   apis                        github:index/repositoryRuleset:RepositoryRuleset  update
~   charts                      github:index/repositoryRuleset:RepositoryRuleset  update
~   enclave                     github:index/repositoryRuleset:RepositoryRuleset  update
~   devctl                      github:index/repositoryRuleset:RepositoryRuleset  update
~   aferox                      github:index/repositoryRuleset:RepositoryRuleset  update
~   go-make                     github:index/repositoryRuleset:RepositoryRuleset  update
~   game                        github:index/repositoryRuleset:RepositoryRuleset  update
~   kubepkgs                    github:index/repositoryRuleset:RepositoryRuleset  update
~   nift                        github:index/repositoryRuleset:RepositoryRuleset  update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant