Repository navigation
Correct convergence value calculation to match Equation 11 of Crane - #61
Merged
Merged
Conversation
timothy-nunn
marked this pull request as ready for review
October 19, 2026 08:42
timothy-nunn
force-pushed
the
convergence-abs-sum-order
branch
2 times, most recently
from
October 19, 2026 08:50
8f8ba9e to
87a3de2
Compare
timothy-nunn
force-pushed
the
convergence-abs-sum-order
branch
from
October 19, 2026 10:37
87a3de2 to
9025bf8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation of the 'convergence value' is wrong according to the Crane report