Skip to content

Varyrun example and test - #4716

Merged
timothy-nunn merged 6 commits into
mainfrom
varyrun-example-and-test
Oct 28, 2026
Merged

timothy-nunn merged 6 commits into
mainfrom
varyrun-example-and-test

Conversation

@clmould

@clmould clmould commented Oct 27, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Closes #4715

Example now find converging IN.DAT
VaryRun raises Error if unable to find converging IN.DAT within max number of allowed iterations - clearer to user instead of just printing to terminal
Remove unused/nonexistent parameters from test run_process.conf

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@codecov-commenter

codecov-commenter commented Oct 27, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.26%. Comparing base (dcdedfd) to head (3390471).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
process/core/io/vary_run/config.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4716      +/-   ##
==========================================
- Coverage   50.26%   50.26%   -0.01%     
==========================================
  Files         181      181              
  Lines       30629    30632       +3     
==========================================
+ Hits        15395    15396       +1     
- Misses      15234    15236       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@clmould
clmould marked this pull request as ready for review October 28, 2026 09:37
@clmould
clmould requested a review from a team as a code owner October 28, 2026 09:37
Comment thread examples/vary_run_example.ex.py Resolved
@clmould
clmould requested a review from timothy-nunn October 28, 2026 11:50
Comment thread examples/vary_run_example.ex.py Resolved
@clmould
clmould requested a review from timothy-nunn October 28, 2026 14:27
@timothy-nunn
timothy-nunn merged commit e122edb into main Oct 28, 2026
10 of 11 checks passed
@timothy-nunn
timothy-nunn deleted the varyrun-example-and-test branch October 28, 2026 15:20
@clmould clmould mentioned this pull request Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VaryRun example file no longer finding converging IN.DAT

3 participants