fix(queue): ISS-013 keep DLQ reconciliation retrying - #680
Open
sbalabanov wants to merge 1 commit into
Open
Conversation
|
|
sbalabanov
commented
Sep 8, 2026
| // A zero budget is not "dead-letter immediately" — it is unconfigured, | ||
| // and the poll loop still governs. | ||
| {name: "unset budget never dead-letters here", attempt: 9}, | ||
| {name: "unlimited budget keeps retrying beyond former cap", attempt: 1001}, |
Contributor
Author
There was a problem hiding this comment.
no need for this regression test
Contributor
Author
There was a problem hiding this comment.
Removed the unnecessary regression test in ee84d5f. The remaining table cases cover retry-budget behavior without testing the former implementation cap.
[addressed by agent]
Summary: Intent: - Keep final-DLQ reconciliation durable during dependency outages longer than any finite attempt budget. - Preserve finite retry budgets for primary subscriptions. Changes: - Define MaxAttempts zero as unlimited in both direct Nack and visibility-expiry poll paths. - Configure the shared DLQ subscription for unlimited retries with second-level dead-lettering disabled. - Verify the orchestrator pipeline and Runway wiring inherit the shared behavior and update the operational docs. Reproduction: - A signal or storage dependency remains unavailable for more than 1000 DLQ reconciliation attempts. - Previously the finite cap was exhausted; because the reconciliation subscription had its own DLQ disabled, MySQL acknowledged the row and advanced past it, losing the reconciliation message. - The row now remains retryable until reconciliation succeeds or an operator removes it. --- <sub>Generated by the 🪄 [pr-create](https://sg.uberinternal.com/code.uber.internal/uber-code/devexp-agent-marketplace/-/blob/claude-code/plugins/dev/uber-dev/skills/pr-create/SKILL.md) skill in devexp-agent-marketplace</sub>
sbalabanov
force-pushed
the
sergeyb/fix-iss-013-unbounded-dlq-retry
branch
from
September 8, 2026 22:56
68fa422 to
ee84d5f
Compare
sbalabanov
marked this pull request as ready for review
September 8, 2026 22:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Intent:
Changes:
Reproduction:
Generated by the 🪄 pr-create skill in devexp-agent-marketplace
Test Plan
AI Verification
0 issues detected
Skipped validators: claude · EngWiki