fix(runway): ISS-010 stop logging queue credentials - #676
Merged
Conversation
|
|
sbalabanov
commented
Sep 8, 2026
| @@ -0,0 +1,80 @@ | |||
| // Copyright (c) 2026 Uber Technologies, Inc. | |||
Contributor
Author
There was a problem hiding this comment.
no need for tests for this change, remove test file from the change
Contributor
Author
There was a problem hiding this comment.
Removed the test file and its BUILD entries in cd36fb2, keeping the change focused on removing the credential-bearing log field.
[addressed by agent]
Summary:
Intent:
- Prevent QUEUE_MYSQL_DSN credentials and query parameters from appearing in Runway startup logs.
- Preserve a useful queue-initialization signal without rendering connection configuration.
Changes:
- Log the queue backend instead of the raw DSN.
- Add observer-based regression coverage with sentinel username, password, and query values.
Reproduction:
- Before: `QUEUE_MYSQL_DSN=user:super-secret@tcp(mysql:3306)/submitqueue?parseTime=true` produced `initialized queue {"dsn":"user:super-secret@tcp(mysql:3306)/submitqueue?parseTime=true"}`.
- After: the same configuration produces `initialized queue {"backend":"mysql"}` with no DSN components.
---
<sub>Generated by the 🪄 [pr-create](https://sg.uberinternal.com/code.uber.internal/uber-code/devexp-agent-marketplace/-/blob/claude-code/plugins/dev/uber-dev/skills/pr-create/SKILL.md) skill in devexp-agent-marketplace</sub>
sbalabanov
force-pushed
the
sergeyb/fix-iss-010-redact-queue-dsn
branch
from
September 8, 2026 23:04
f982cd4 to
cd36fb2
Compare
sbalabanov
marked this pull request as ready for review
September 8, 2026 23:05
behinddwalls
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Intent
QUEUE_MYSQL_DSNcredentials and query parameters from appearing in Runway startup logs.Changes
Reproduction
Before the fix, starting Runway with
QUEUE_MYSQL_DSN=user:super-secret@tcp(mysql:3306)/submitqueue?parseTime=trueproducedinitialized queue {"dsn":"user:super-secret@tcp(mysql:3306)/submitqueue?parseTime=true"}.After the fix, the same configuration produces
initialized queue {"backend":"mysql"}with no DSN components.Generated by the 🪄 pr-create skill in devexp-agent-marketplace