refactor: separate land workflow from runway merge - #674
Closed
behinddwalls wants to merge 1 commit into
Closed
Conversation
behinddwalls
marked this pull request as ready for review
September 4, 2026 03:30
behinddwalls
force-pushed
the
land-terminology
branch
from
September 4, 2026 11:10
a7aac77 to
4690c6d
Compare
sbalabanov
requested changes
Sep 4, 2026
sbalabanov
left a comment
sbalabanov
left a comment
Contributor
There was a problem hiding this comment.
Stopped reviewing here, sending back for a discussion on where the boundary between "land" and "merge" should be
behinddwalls
force-pushed
the
land-terminology
branch
from
September 7, 2026 21:03
4690c6d to
562d335
Compare
behinddwalls
changed the title
## Summary ### Why? SubmitQueue owns the user-facing land workflow, while Runway owns the merge execution contract. Renaming the established Runway wire types and topics would blur that boundary and introduce an unnecessary contract migration. ### What? Keep SubmitQueue APIs, lifecycle states, controllers, internal topics, CLI, and documentation in land terminology. Preserve Runway `MergeRequest`, `MergeStep`, `MergeResult`, merge controllers, extensions, configuration, and existing merge topic names, with explicit translation at the validation, land-dispatch, and result-signal boundaries. Restore the shared `mergestrategy` contract and preserve every strategy mapping, including `PROMOTE`. Tighten the dependent-batch E2E fixture so it deterministically exercises wake-up from a Runway merge result rather than complete-coverage bypass. Remove the unused in-process `landchecker` extension and its fake, GitHub, and mock implementations. Remove the orphaned `LandCheckResult`, `PushResult`, `OutcomeStatus`, `ChangeOutcome`, and `BatchOutcome` entities because Runway is now the sole validation and merge-execution boundary. ## Test Plan - ✅ `make proto` - ✅ `make mocks` - ✅ `make gazelle` - ✅ `make fmt` - ✅ `make tidy` - ✅ `make build` - ✅ `make test` - ✅ `make lint` - ✅ `make check-tidy` - ✅ `make check-gazelle` - ✅ Targeted Runway contract, controller, extension, DLQ, and SubmitQueue boundary tests - ✅ Runway E2E suite - ✅ SubmitQueue E2E suite
behinddwalls
force-pushed
the
land-terminology
branch
from
September 7, 2026 22:02
562d335 to
6191982
Compare
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why?
SubmitQueue owns the user-facing land workflow, while Runway owns the merge execution contract. Renaming the established Runway wire types and topics would blur that boundary and introduce an unnecessary contract migration.
What?
Keep SubmitQueue APIs, lifecycle states, controllers, internal topics, CLI, and documentation in land terminology. Preserve Runway
MergeRequest,MergeStep,MergeResult, merge controllers, extensions, configuration, and existing merge topic names, with explicit translation at the validation, land-dispatch, and result-signal boundaries.Restore the shared
mergestrategycontract and preserve every strategy mapping, includingPROMOTE. Tighten the dependent-batch E2E fixture so it deterministically exercises wake-up from a Runway merge result rather than complete-coverage bypass.Remove the unused in-process
landcheckerextension and its fake, GitHub, and mock implementations. Remove the orphanedLandCheckResult,PushResult,OutcomeStatus,ChangeOutcome, andBatchOutcomeentities because Runway is now the sole validation and merge-execution boundary.Test Plan
make protomake mocksmake gazellemake fmtmake tidymake buildmake testmake lintmake check-tidymake check-gazelleStack