Repository navigation
Let the official embed script work without runtime URL attributes - #104
Merged
Merged
Conversation
The widget only went live when the script tag also carried data-skilly-backend-url and data-skilly-core-url, so Studio's onboarding install snippet (which omits them) produced a widget stuck in simulated mode, and every other snippet needed two noisy lines. When the script is served from cdn.tryskilly.app, default to Studio's backend and the CDN core; explicit attributes still win, and self-hosted or local copies keep today's behavior. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The web widget only connects to Studio when the script tag carries
data-skilly-backend-url(+data-skilly-core-urlfor the WASM core). Studio's onboarding install snippet omits them, so widgets installed from it stayed in simulated mode, and every other snippet needed two noisy lines.resolveEmbedRuntimeUrls: when the script is served fromcdn.tryskilly.app, defaultbackendUrltohttps://studio.tryskilly.appandcoreUrlto/web/v1.0.0/skilly_core_web_sdk.json the same CDN. Explicit attributes still win; self-hosted/local copies (demo, tests) are unchanged.Merging deploys
/web/v1.jsvia the Deploy Web CDN workflow (5-minute cache). A follow-up drops the two lines from Studio's snippets once this is live.Verified:
sdk/webbun test26/26 (3 new),tsc --noEmit,tsupbuild.🤖 Generated with Claude Code