Repository navigation
[fix] Use fully qualified names for in-cluster service URLs - #409
Open
eabrouwer3 wants to merge 4 commits into
Open
eabrouwer3 wants to merge 4 commits into
eabrouwer3 wants to merge 4 commits into
Conversation
The backend's HTTP client resolves hosts with cacheable-lookup, which calls dns.resolve4/resolve6 (c-ares) and never applies the resolv.conf search list. A bare service name such as `retool-code-executor` only works today because most cluster DNS servers answer it with NXDOMAIN, which makes cacheable-lookup fall back to dns.lookup. EKS Auto Mode's DNS answers REFUSED and AKS's answers SERVFAIL, so the fallback never runs and the backend crash-loops with "Could not detect healthy Code Executor". Append `.<namespace>.svc.cluster.local` to every in-cluster service URL and host the chart passes to Retool, matching the agent-sandbox proxy URL the chart already builds this way. Fixes tryretool#348. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
 [Medium impact] The PR appears safe to merge; both previous findings are addressed and no new actionable issues were found. Reviews (2) · Last reviewed commit: "[chore] Keep the Temporal host comment w..." · Reviewed by Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Add a clusterDomain value (default cluster.local) and a retool.serviceDomain helper, and build every in-cluster service address from it, including the existing agent-sandbox proxy URL. Hard-coding svc.cluster.local would break clusters with a different DNS domain, where the bare names used to resolve through the search list. Also qualify WORKFLOW_BACKEND_HOST and JS_EXECUTOR_INGRESS_DOMAIN in the separate app-serving layer, which the previous commit missed. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The new serviceDomain helper sat between "Set Temporal frontend host" and the helper that comment describes, with a docstring that only restated what the helper's one line does. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-Authored-By: gpt-6.1-sol <codex@openai.com>
eabrouwer3
marked this pull request as ready for review
October 20, 2026 18:32
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
justinyang-retool
approved these changes
Oct 21, 2026
# Conflicts: # charts/retool/Chart.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #348.
Retool's HTTP client uses
cacheable-lookup, which resolves bare service names without applying the DNS search list inresolv.conf. Its fallback todns.lookupruns only forENOTFOUND/ENODATA; EKS Auto Mode returnsREFUSED, and AKS returnsSERVFAIL(#339), leaving the backend crash-looping withCould not detect healthy Code Executor. Overriding.Values.envduplicates the chart's entry and is rejected by server-side apply.The templates in
charts/retool/templates/append.<namespace>.svc.<clusterDomain>to chart-generated in-cluster hosts, including the workflow backend and JS executor hosts consumed bycharts/retool/templates/deployment_rr_app_serving_layer.yaml.clusterDomaindefaults tocluster.localand supports clusters with a custom DNS domain. Object names and explicit URL overrides are unchanged.charts/retool/Chart.yamlbumps the chart to 6.13.3.Rendering checks found only the intended host changes and confirmed custom-domain support. We run a backport of this change on EKS Auto Mode (Retool 4.34.9, chart 6.12.3): the backend, workflow backend and workflow worker now reach the code executor, where the unpatched chart crash-looped.