Repository navigation
fix: revert breaking dependency versions on main - #322
Merged
Merged
Conversation
hmac 0.13, deadpool-lapin 0.14, config 0.15, derive_builder 0.20, and dialoguer 0.12 have breaking API changes the code is not adapted to. Revert to the versions dev compiles against: - hmac 0.13.0 -> 0.12.1 (Hmac::new_from_slice removed in 0.13) - deadpool-lapin 0.14.0 -> 0.12.1 (create_pool signature changed) - config 0.15.0 -> 0.13.4 - derive_builder 0.20.0 -> 0.12.0 - dialoguer 0.12 -> 0.11 russh still pulls hmac 0.13 transitively for its own use; the direct hmac 0.12 dependency keeps the code's imports on the old API. Also allowlist Cargo.lock checksums in check-staged-secrets.sh.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Main build fails with
hmac 0.13,deadpool-lapin 0.14,config 0.15,derive_builder 0.20, anddialoguer 0.12- these have breaking API changes the code is not adapted to.Fix
Revert to the versions
devcompiles against:hmac 0.13.0->0.12.1(Hmac::new_from_slice removed in 0.13)deadpool-lapin 0.14.0->0.12.1(create_pool signature changed)config 0.15.0->0.13.4derive_builder 0.20.0->0.12.0dialoguer 0.12->0.11russhstill pullshmac 0.13transitively for its own use; the directhmac 0.12dependency keeps the code's imports on the old API.Also allowlist Cargo.lock checksums in
check-staged-secrets.sh(public crate hashes, not secrets).Verified
SQLX_OFFLINE=true cargo checkpasses locally.