Repository navigation
fix(web): keep pagination inside the card and make the logo visible - #18
Merged
Merged
Conversation
vsilent
commented
Nov 2, 2026
vsilent
commented
- Alert pagination rendered one button per page: 2711 buttons at 27k alerts, in one unwrapped row spilling across the whole viewport. Windowed to first, last, current +/-1 with ellipses. The page also resets to 1 when the filter changes, so a filtered list cannot show an empty table behind stale page buttons.
- The sidebar logo was loaded from a remote URL (blank whenever that host is unreachable) and is a black silhouette on a dark sidebar either way. Bundled as web/src/assets/logo.png with the webpack asset rule and TypeScript declarations, drawn inverted (white) via CSS.
- Verified: web jest suite 54/54, production webpack build passes.
The alert list rendered one pagination button per page. At 27k alerts that is 2711 buttons in one unwrapped row, spilling across the whole viewport. Window the pages: first, last, current +/-1, ellipses. Also reset to page 1 when the filter changes, so a filtered list cannot show an empty table behind page buttons from the previous total. The sidebar logo was loaded from a remote URL, blank whenever that host is unreachable, and the artwork is a black silhouette on a dark sidebar either way. Bundle it as web/src/assets/logo.png with the webpack asset rule and TypeScript declarations, and draw it inverted (white) via CSS. cargo test is unaffected; web jest suite 54/54 and the production webpack build pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.