Repository navigation
Conversation
Connections that send nothing could hold every maxHttpConnectNumber slot until the connector's 30-second idle timeout and lock other clients out. When the limit is reached, the open connections now time out after 10 seconds of inactivity. Connections still being accepted at that moment keep the connector's default idle timeout.
halibobo1205
approved these changes
Oct 12, 2026
bladehan1
reviewed
Oct 12, 2026
bladehan1
approved these changes
Oct 13, 2026
halibobo1205
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
node.maxHttpConnectNumber(default 50) is reached:HttpServicesetsConnectionLimit.setIdleTimeout(10_000).ConnectionLimitTest. The idle timeout can be set through a@VisibleForTestingsetter, so the test runs with 1 second instead of 10.Why are these changes required?
At the connection limit Jetty stops accepting, and a connection that never sends a request holds its slot until the connector's 30-second idle timeout has fired twice (Jetty half-closes an idle connection before closing it), about 60 seconds. Meanwhile other HTTP / JSON-RPC clients are locked out. The new timeout applies only while the limit is reached and frees such a slot in about 20 seconds.
This PR has been tested by:
ConnectionLimitTestpasses in about 2 seconds and fails with a read timeout when thesetIdleTimeoutcall is removed;SizeLimitHandlerTest,HttpApiAccessFilterTest,HttpInterceptorMetricsTestand checkstyle pass.Follow up
None.
Extra details