fix(PM-6415): allow talent managers access to non-internal projects - #47
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the service portion of PM-6415.
Talent Managers and Topcoder Talent Managers can list and directly open projects without membership. Projects assigned to a configured internal billing account are excluded from list results and totals, and blocked on direct project and nested project routes, including when membership is already cached.
Set
INTERNAL_BILLING_ACCOUNT_IDSto the comma-separated internal BA IDs before deployment. Empty configuration excludes no accounts; malformed IDs reject requests rather than silently applying a partial exclusion list. Projects without a BA remain visible, and administrator/M2M policies are preserved.memberOnly=trueretains membership/pending-invite filtering and still excludes internal projects. The companion platform-ui PR exposes My Projects to both TM role variants.Validation:
pnpm lint,pnpm build, and 53 tests covering list visibility, direct non-member access, internal-account filtering, cached nested-route denial, and role/configuration edge cases. Dependencies and Prisma clients were installed/generated for this worktree from its frozen lockfile.Companion UI PR: topcoder-platform/platform-ui#2401