fix(PM-6433): show forum member autocomplete dropdown - #2404
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the dropdown visibility follow-up for PM-6433.
Typing
@toursuccessfully returnedtourist, but the suggestion list was positioned below the textarea and clipped by the editor shell'soverflow: hidden. The shared forum editor now allows that list to extend below its border, with rounded-corner clipping applied only to the toolbar and the textarea/preview corners styled explicitly.This applies to topic creation, comments, replies, and edit composers that share the editor.
Validation:
yarn lint; 27 passing forum/editor tests; production build withNODE_OPTIONS=--max-old-space-size=8192; a compiled SCSS/JSDOM check confirms that the original shell clips suggestions and the patched create-topic ancestor chain does not. Browser automation was unavailable, so no visual browser verification was performed.