Skip to content

feat: use CSS nesting and switch from clean-css to lightningcss #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tomherni merged 2 commits into from
Jun 17, 2026
Merged

feat: use CSS nesting and switch from clean-css to lightningcss #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c656945
chore: replace clean-css with lightningcss
tomherni Jun 16, 2026
0af8a27
feat: use CSS nesting
tomherni Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
287 changes: 274 additions & 13 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,18 +20,17 @@
},
"devDependencies": {
"@eslint/js": "^10.0.1",
"@types/clean-css": "^4.2.11",
"@types/html-minifier-terser": "^7.0.2",
"@types/js-yaml": "^4.0.9",
"@types/node": "^24.13.2",
"@types/prismjs": "^1.26.3",
"canvas": "^3.0.1",
"clean-css": "^5.3.3",
"eslint": "^10.5.0",
"globals": "^17.6.0",
"html-minifier-terser": "^7.2.0",
"husky": "^9.1.7",
"js-yaml": "^4.1.0",
"lightningcss": "^1.32.0",
"lint-staged": "^17.0.7",
"marked": "^11.1.0",
"prettier": "^3.8.4",
Expand Down
9 changes: 5 additions & 4 deletions src/generator/optimize/optimize.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import CleanCSS from 'clean-css';
import { transform } from 'lightningcss';
import crypto from 'node:crypto';
import fs from 'node:fs';
import path from 'node:path';
Expand Down Expand Up @@ -32,9 +32,10 @@ export async function optimize(): Promise<void> {
*/
function optimizeCssFiles(): void {
for (const file of findFilesByExtension('css', DIR_DIST)) {
const input = fs.readFileSync(file, 'utf8');
const minified = new CleanCSS().minify(input).styles;
fs.writeFileSync(file, minified);
const input = fs.readFileSync(file);
// `filename` is required but unused.
const { code } = transform({ filename: 'foo', code: input, minify: true });
fs.writeFileSync(file, code);
}
}

Expand Down
Loading