Repository navigation
Conversation
klauspost
approved these changes
Oct 19, 2026
Member
|
The original bug report wasn't entirely coherent. The implementation of There's a separate issue where perhaps disabling generation of Marshal/Unmarshal code altogether would cause a problem, as the EncodeDecode generated test depends on Msgsize() existing, but that's a different issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
-marshal=false,//msgp:size ignore Streamproduces usable stream methods, but its generated test fails to compile because it still calls the omittedMsgsizemethod. Check the existingmsgp.Sizerinterface before performing that optional size check. Encoding, decoding, and skip tests remain intact, including size checks and warnings for generated or manually supplied sizers.Fixes #140. The regression covers exact and regex ignore directives, normal size generation, and a custom pointer sizer. It checks literal wire bytes, a nonzero stream round trip, and preservation of the custom size warning. The two ignored-size cases fail against the unchanged generator and pass with this change.
Validation on Go 1.26.2 / macOS ARM64:
go vet ./... ./_generated, formatting, and CI-pinned golangci-lint 2.5.0 (./...) pass.Local limits: Go 1.24/1.25, Linux, TinyGo, race checks, benchmarks, and fuzz campaigns were not run. The runtime run also excludes
TestConv32,TestConv64,TestReadIntfRecursion,TestSkipRecursion, 11 examples, and ordinary seeds for five fuzz functions. A combined test invocation stopped at a local resource threshold; the reported results come from subsequent completed sequential runs.AI assistance: Codex assisted with the implementation, tests, and description. A separate agent independently reviewed the exact change and verification evidence.