Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Named
as:targets were classified as IDENT without enabling conversion, so cast shims ignored theirusing:serializer. Pointer shims could generate invalid expressions such as&field.MarshalMsg(...). Enable conversion locally for named cast shims; primitive shims, ordinary aliases, andmode:convertretain their existing behavior.Fixes #439. The regression generates a named map serializer and checks wire bytes, all five methods, zero-value decoding, nil pointers, container fields, and decode errors. The same valid fixture fails to compile with the upstream generator.
Validation on Go 1.26.2 / macOS ARM64:
go vet, gofmt, and CI-pinned golangci-lint 2.5.0 (./...) pass.TestConv32,TestConv64,TestReadIntfRecursion,TestSkipRecursion, fuzzing, and benchmarks were not run locally.AI assistance: Codex assisted with the implementation, tests, and description. A separate agent reviewed the change.