Repository navigation
edit: read bin-typed map keys - #454
Merged
Merged
Conversation
HasKey, locate and locateKV read keys with ReadStringZC, so a key encoded as bin stopped the scan. Use ReadMapKeyZC, as ReadMapStrIntfBytes does.
klauspost
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HasKey,locateandlocateKVinmsgp/edit.goread map keys withReadStringZC, so a key encoded asbinstops the scan:Locate,HasKey,Replace,CopyReplaceandRemovemiss every field at or after it. The README says the deserializers acceptbinmap keys, and #450 switchedReadMapStrIntffor the same reason. This usesReadMapKeyZC, likeReadMapStrIntfBytes.TestEditBinKeyswrites a map whose first key isbinand checksLocate/HasKeyfor both keys and a missing one,CopyReplaceandRemove. It fails on master.Written with AI assistance (Claude); I have reviewed the change.